Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: Add SQL mode details #728

Merged
merged 4 commits into from
Nov 20, 2018
Merged

sql: Add SQL mode details #728

merged 4 commits into from
Nov 20, 2018

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Nov 11, 2018

Fixes #606.

Depends on NO_AUTO_CREATE_USER being merged, but expected soon:
pingcap/tidb#8160

@morgo
Copy link
Contributor Author

morgo commented Nov 11, 2018

@zz-jason @shenli PTAL

@morgo morgo mentioned this pull request Nov 19, 2018
Merged
@shenli
Copy link
Member

shenli commented Nov 20, 2018

LGTM
@jackysp PTAL

zz-jason
zz-jason approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenli shenli merged commit 83df693 into master Nov 20, 2018
@shenli shenli deleted the morgo/sql-mode branch November 20, 2018 17:52
@CaitinChen CaitinChen mentioned this pull request Nov 29, 2018
Merged
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sql: Document which sql_modes are supported
4 participants
@morgo @shenli @zz-jason @sre-bot