This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
support specialized csv separator and delimiter #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
- Coverage 51.92% 50.76% -1.17%
==========================================
Files 17 17
Lines 1770 1775 +5
==========================================
- Hits 919 901 -18
- Misses 782 811 +29
+ Partials 69 63 -6 |
kennytm
reviewed
Jul 7, 2020
v4/export/sql_type.go
Outdated
| @@ -153,11 +153,11 @@ func (r RowReceiverArr) WriteToBuffer(bf *bytes.Buffer, escapeBackslash bool) { | |||
| bf.WriteByte(')') | |||
| } | |||
|
|
|||
| func (r RowReceiverArr) WriteToBufferInCsv(bf *bytes.Buffer, escapeBackslash bool, csvNullValue string) { | |||
| func (r RowReceiverArr) WriteToBufferInCsv(bf *bytes.Buffer, escapeBackslash bool, opt csvOption) { | |||
There was a problem hiding this comment.
pass this by reference please (also all other occurrences)
Suggested change
| func (r RowReceiverArr) WriteToBufferInCsv(bf *bytes.Buffer, escapeBackslash bool, opt csvOption) { | |
| func (r RowReceiverArr) WriteToBufferInCsv(bf *bytes.Buffer, escapeBackslash bool, opt *csvOption) { |
| "2;'female';'sarah@mail.com';'020-1253';'healthy'\n" + | ||
| "3;'male';'john@mail.com';'020-1256';'healthy'\n" + | ||
| "4;'female';'sarah@mail.com';'020-1235';'healthy'\n" | ||
| c.Assert(bf.String(), Equals, expected) |
There was a problem hiding this comment.
please include a test case where separator has multiple characters and delimiter is "ma" (male should become mamamalema, femail should become mafemamalema, xxx@mail.com should become maxxx@mamail.comma).
There was a problem hiding this comment.
addressed in 7eb9742
kennytm
approved these changes
Jul 8, 2020
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* support specialized csv separator and delimiter * address comments * address comment
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* support specialized csv separator and delimiter * address comments * address comment
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* support specialized csv separator and delimiter * address comments * address comment
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* support specialized csv separator and delimiter * address comments * address comment
tisonkun
pushed a commit
to tisonkun/tidb
that referenced
this pull request
Oct 20, 2021
* support specialized csv separator and delimiter * address comments * address comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Resolve #113
What is changed and how it works?
Add arguments "csv-separator" and "csv-delimiter" to support specialized csv separator and delimiter.
Check List
Tests
Side effects
Related changes
Release note