This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
fix consistency bug #128
Merged
fix consistency bug #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 50.75% 50.78% +0.02%
==========================================
Files 17 17
Lines 1909 1910 +1
==========================================
+ Hits 969 970 +1
- Misses 868 869 +1
+ Partials 72 71 -1 |
overvenus
reviewed
Aug 6, 2020
v4/export/sql.go
Outdated
| func FlushTableWithReadLock(db *sql.DB) error { | ||
| _, err := db.Exec("FLUSH TABLES WITH READ LOCK") | ||
| func FlushTableWithReadLock(db *sql.Conn) error { | ||
| _, err := db.ExecContext(context.Background(), "FLUSH TABLES WITH READ LOCK") |
There was a problem hiding this comment.
Please avoiding context.Background().
There was a problem hiding this comment.
addressed, PTAL again
overvenus
reviewed
Aug 7, 2020
v4/export/consistency.go
Outdated
| serverType ServerType | ||
| db *sql.DB | ||
| conn *sql.Conn | ||
| } | ||
|
|
||
| func (c *ConsistencyFlushTableWithReadLock) Setup() error { |
There was a problem hiding this comment.
What about
Suggested change
| func (c *ConsistencyFlushTableWithReadLock) Setup() error { | |
| func (c *ConsistencyFlushTableWithReadLock) Setup(ctx context.Context) error { |
v4/export/consistency.go
Outdated
| } | ||
|
|
||
| type ConsistencyLockDumpingTables struct { | ||
| db *sql.DB | ||
| ctx context.Context |
There was a problem hiding this comment.
tests/consistency/run.sh
Outdated
|
|
||
| # dumping with consistency flush | ||
| export DUMPLING_TEST_DATABASE=$DB_NAME | ||
| export GO_FAILPOINTS="github.com/pingcap/dumpling/v4/export/ConsistencyCheck=return(\"5s\")" |
There was a problem hiding this comment.
Suggested change
| export GO_FAILPOINTS="github.com/pingcap/dumpling/v4/export/ConsistencyCheck=return(\"5s\")" | |
| export GO_FAILPOINTS="github.com/pingcap/dumpling/v4/export/ConsistencyCheck=1*sleep(5000)" |
v4/export/dump.go
Outdated
Comment on lines
169
to
177
| failpoint.Inject("ConsistencyCheck", func(val failpoint.Value) { | ||
| interval, err := time.ParseDuration(val.(string)) | ||
| if err != nil { | ||
| log.Warn("inject failpoint ConsistencyCheck failed", zap.Reflect("value", val), zap.Error(err)) | ||
| } else { | ||
| log.Info("start to sleep for failpoint ConsistencyCheck", zap.Duration("sleepTime", interval)) | ||
| time.Sleep(interval) | ||
| } | ||
| }) |
There was a problem hiding this comment.
Suggested change
| failpoint.Inject("ConsistencyCheck", func(val failpoint.Value) { | |
| interval, err := time.ParseDuration(val.(string)) | |
| if err != nil { | |
| log.Warn("inject failpoint ConsistencyCheck failed", zap.Reflect("value", val), zap.Error(err)) | |
| } else { | |
| log.Info("start to sleep for failpoint ConsistencyCheck", zap.Duration("sleepTime", interval)) | |
| time.Sleep(interval) | |
| } | |
| }) | |
| failpoint.Inject("consistency-check", nil) |
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* fix consistency problem * add consistency integration test * address comment * address comments
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* fix consistency problem * add consistency integration test * address comment * address comments
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* fix consistency problem * add consistency integration test * address comment * address comments
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* fix consistency problem * add consistency integration test * address comment * address comments
tisonkun
pushed a commit
to tisonkun/tidb
that referenced
this pull request
Oct 20, 2021
* fix consistency problem * add consistency integration test * address comment * address comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
unlock tables;to unlock the FTWRL lock it actually doesn't take effect. Because dumpling usesql.DBto unlock tables butFTWRLneed to be unlocked by the original connection.consistent snapshot, so we should record it before FTWRL is released.What is changed and how it works?
Check List
Tests
Side effects
Related changes
Release note