This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Fix: dump all generated column table #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lance6716
reviewed
Oct 18, 2020
kennytm
reviewed
Oct 19, 2020
There was a problem hiding this comment.
thanks for the PR.
when a table contains only generated columns, it should produce an output with COUNT(*) empty rows, rather than skipping the table entirely, for instance producing
INSERT INTO `the_table` VALUES
(),
(),
(),
(),
();could you add a test for that (e.g. reuse tests/ignore_generate_column)?
(you could use the CI if setting up the environment is too hard 😛)
…ix_all_generated_column
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* Fix dump all generated column table
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* Fix dump all generated column table
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* Fix dump all generated column table
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* Fix dump all generated column table
tisonkun
pushed a commit
to tisonkun/tidb
that referenced
this pull request
Oct 20, 2021
* Fix dump all generated column table
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #145
What is changed and how it works?
Handling the case where selected field is empty
Check List
Tests
Side effects
Related changes
Release note