Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

skip concurrent dump due to no valid smax or smin #189

Merged
merged 1 commit into from
Nov 6, 2020
Merged

skip concurrent dump due to no valid smax or smin #189

merged 1 commit into from
Nov 6, 2020

Conversation

jiyfhust
Copy link
Contributor

@jiyfhust jiyfhust commented Nov 6, 2020

What problem does this PR solve?

#186

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lichunzhu
Copy link
Contributor

Could you please sign the CLA? Contributor License Agreement

lichunzhu
lichunzhu approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiyfhust
Copy link
Contributor Author

jiyfhust commented Nov 6, 2020

Yes. I have signed it.

@lichunzhu lichunzhu merged commit d7eb9c0 into pingcap:master Nov 6, 2020
@lichunzhu
Copy link
Contributor

OK, thanks a lot!

@lichunzhu lichunzhu linked an issue Nov 6, 2020 that may be closed by this pull request
Judge table has no data wrong #186
Closed
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
@jiyfhust
skip concurrent dump due to no valid smax or smin (pingcap#189)
e6a26b3
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
@jiyfhust
skip concurrent dump due to no valid smax or smin (pingcap#189)
0c5bb9a
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
@jiyfhust
skip concurrent dump due to no valid smax or smin (pingcap#189)
bc6c40d
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
@jiyfhust
skip concurrent dump due to no valid smax or smin (pingcap#189)
084506e
tisonkun pushed a commit to tisonkun/tidb that referenced this pull request Oct 20, 2021
@jiyfhust @tisonkun
skip concurrent dump due to no valid smax or smin (pingcap/dumpling#189)
77a4698
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Judge table has no data wrong
3 participants
@jiyfhust @CLAassistant @lichunzhu