This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
rebuild mysql conn when retry failed chunks and support --transactional-consistency parameter
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be merged after #190 |
|
i suggest we avoid the obscure abbreviation since |
I think changing the name is okay, but we should keep this behavior the same as before, which means |
|
Yes the default should be 1. |
|
fix some typo in 91dcef2 |
kennytm
approved these changes
Nov 16, 2020
lichunzhu
added
status/LGT1
Closed
lichunzhu
changed the title
trx-consistency-only parameter--transactional-consistency parameter
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
…l-consistency` parameter (pingcap#199) * support rebuild mysql connection to retry failed chunks * refine consistency variables * add --transactional-consistency and support rebuilding mysql conn to retry
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
…l-consistency` parameter (pingcap#199) * support rebuild mysql connection to retry failed chunks * refine consistency variables * add --transactional-consistency and support rebuilding mysql conn to retry
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
…l-consistency` parameter (pingcap#199) * support rebuild mysql connection to retry failed chunks * refine consistency variables * add --transactional-consistency and support rebuilding mysql conn to retry
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
…l-consistency` parameter (pingcap#199) * support rebuild mysql connection to retry failed chunks * refine consistency variables * add --transactional-consistency and support rebuilding mysql conn to retry
tisonkun
pushed a commit
to tisonkun/tidb
that referenced
this pull request
Oct 20, 2021
…l-consistency` parameter (pingcap/dumpling#199) * support rebuild mysql connection to retry failed chunks * refine consistency variables * add --transactional-consistency and support rebuilding mysql conn to retry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#178
When we retry on failed chunks, if mysql connection is broken, the retry will fail directly and will take no effect.
What is changed and how it works?
--transactional-consistencyoption. The default value is true. If it isfalse, dumpling won't release locks until the dumping progress is finished.--transactional-consistency= false). Before rebuilding MySQL connection we should also check that whether the mysql lock connection is still alive.Check List
Tests
Test kill the socket mysql connection. The connection can be rebuilt and dump data correctly.
Side effects
Related changes
Release note
--transactional-consistencyparameter and support rebuild mysql connections during retry.