Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: fix the plugins deps problem #1018

Merged
merged 2 commits into from
Dec 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions configs/queries/company-search/params.json

This file was deleted.

14 changes: 0 additions & 14 deletions configs/queries/company-search/template.sql

This file was deleted.

2 changes: 1 addition & 1 deletion packages/api-server/__tests__/queries.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { buildParams, eachQuery } from './helpers/queries';
import { QueryParser } from '../src/core/runner/query/QueryParser';
import { CollectionService } from '../src/services/collection-service';
import { CollectionService } from '../src/plugins/services/collection-service';
import { testLogger } from './helpers/log';
import CacheBuilder from '../src/core/cache/CacheBuilder';
import {TiDBQueryExecutor} from "../src/core/executor/query-executor/TiDBQueryExecutor";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {bootstrapTestDatabase, getTestDatabase, releaseTestDatabase} from '../helpers/db';
import { CollectionService } from '../../src/services/collection-service';
import { CollectionService } from '../../src/plugins/services/collection-service';
import { testLogger } from '../helpers/log';
import CacheBuilder from '../../src/core/cache/CacheBuilder';
import {getConnection, getConnectionOptions} from "../../src/core/db/new";
Expand Down
4 changes: 2 additions & 2 deletions packages/api-server/__tests__/services/repo-service.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {bootstrapTestDatabase, releaseTestDatabase, TiDBDatabase} from '../helpers/db';
import {bootstrapApp, StartedApp} from '../helpers/app';
import '../../src/services/repo-service';
import {RepoService, SubscribedRepo} from "../../src/services/repo-service";
import '../../src/plugins/services/repo-service';
import {RepoService, SubscribedRepo} from "../../src/plugins/services/repo-service";
import {Connection} from "mysql2/promise";
import {APIError} from "../../src/utils/error";

Expand Down
2 changes: 1 addition & 1 deletion packages/api-server/__tests__/services/stats-service.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { bootstrapTestDatabase, getTestDatabase, releaseTestDatabase } from '../helpers/db';
import { StatsService } from '../../src/services/stats-service';
import { StatsService } from '../../src/plugins/services/stats-service';
import { testLogger } from '../helpers/log';
import {getPool} from "../../src/core/db/new";

Expand Down
2 changes: 1 addition & 1 deletion packages/api-server/__tests__/services/user-service.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {bootstrapTestDatabase, getTestDatabase, releaseTestDatabase} from '../helpers/db';
import {bootstrapApp, getTestApp, releaseApp} from '../helpers/app';
import {Connection, ResultSetHeader} from "mysql2/promise";
import {ProviderType, UserRole, UserService} from "../../src/services/user-service";
import {ProviderType, UserRole, UserService} from "../../src/plugins/services/user-service";

let userService: UserService, conn: Connection;

Expand Down
6 changes: 0 additions & 6 deletions packages/api-server/src/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,6 @@ const app: FastifyPluginAsync<AppOptions, RawServerDefault, JsonSchemaToTsProvid
options: opts
})

// This loads all plugins defined in services.
void fastify.register(AutoLoad, {
dir: join(__dirname, 'services'),
options: opts
})

// This loads all plugins defined in routes
// define your routes in one of these.
await fastify.register(AutoLoad, {
Expand Down
2 changes: 1 addition & 1 deletion packages/api-server/src/core/runner/query/QueryParser.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { CollectionService } from "../../../services/collection-service";
import { CollectionService } from "../../../plugins/services/collection-service";
import { QuerySchema } from "../../../types/query.schema";

export enum ParamType {
Expand Down
2 changes: 1 addition & 1 deletion packages/api-server/src/plugins/auth/github.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import fastifyOauth2, {FastifyOAuth2Options, OAuth2Namespace} from '@fastify/oau
import {DateTime} from 'luxon';
import fastifyCookie from "@fastify/cookie";
import fp from 'fastify-plugin';
import {ProviderType, UserProfile, UserRole} from "../../services/user-service";
import {ProviderType, UserProfile, UserRole} from "../services/user-service";
import {APIError} from "../../utils/error";
import {getOctokit} from "../../utils/loger";

Expand Down
3 changes: 2 additions & 1 deletion packages/api-server/src/plugins/runner/query/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ export default fp(async (app) => {
dependencies: [
'@fastify/env',
'tidb-query-executor',
'cache-builder'
'cache-builder',
'collection-service'
],
});

Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import CacheBuilder, { CacheProviderTypes } from "../../core/cache/CacheBuilder";
import CacheBuilder, { CacheProviderTypes } from "../../../core/cache/CacheBuilder";

import { CachedData } from "../../core/cache/Cache";
import { CachedData } from "../../../core/cache/Cache";
import { DateTime } from "luxon";
import { RowDataPacket } from "mysql2/promise";
import { TiDBQueryExecutor } from "../../core/executor/query-executor/TiDBQueryExecutor";
import { TiDBQueryExecutor } from "../../../core/executor/query-executor/TiDBQueryExecutor";
import fp from "fastify-plugin";
import pino from "pino";
import {dataQueryTimer, measure, tidbQueryCounter} from "../../plugins/metrics/metrics";
import {dataQueryTimer, measure, tidbQueryCounter} from "../../metrics/metrics";

declare module 'fastify' {
interface FastifyInstance {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import fp from "fastify-plugin";
import {MySQLPromisePool} from "@fastify/mysql";
import {APIError} from "../../utils/error";
import {APIError} from "../../../utils/error";
import {QuestionContext} from "../bot-service";

declare module 'fastify' {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {FastifyOAuth2Options} from "@fastify/oauth2";
import {MySQLPromisePool} from "@fastify/mysql";
import {ResultSetHeader} from "mysql2";
import fp from "fastify-plugin";
import {APIError} from "../../utils/error";
import {APIError} from "../../../utils/error";
import {RowDataPacket} from "mysql2/promise";

declare module 'fastify' {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { BatchLoader } from "../../core/db/batch-loader";
import { BatchLoader } from "../../../core/db/batch-loader";
import {Pool} from "mysql2/promise";
import fp from "fastify-plugin";
import {getPool} from "../../core/db/new";
import {getPool} from "../../../core/db/new";
import pino from "pino";

declare module 'fastify' {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { FastifyOAuth2Options } from "@fastify/oauth2";
import { MySQLPromisePool } from "@fastify/mysql";
import { ResultSetHeader } from "mysql2";
import fp from "fastify-plugin";
import {APIError} from "../../utils/error";
import {APIError} from "../../../utils/error";
import {Connection, RowDataPacket} from "mysql2/promise";

declare module 'fastify' {
Expand Down
2 changes: 1 addition & 1 deletion packages/api-server/src/routes/bot/questionToSQL/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {FastifyPluginAsyncJsonSchemaToTs} from "@fastify/type-provider-json-schema-to-ts";
import {QuestionContext} from "../../../services/bot-service";
import {QuestionContext} from "../../../plugins/services/bot-service";
import {APIError} from "../../../utils/error";

export interface IBody {
Expand Down