Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

const: fix wrong SQL mode const #1008

Merged
merged 7 commits into from
Sep 4, 2020
Merged

const: fix wrong SQL mode const #1008

merged 7 commits into from
Sep 4, 2020

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Sep 4, 2020 •
edited
Loading

What problem does this PR solve?

fix wrong SQL mode introduced in pingcap/tidb#2739, #171

What is changed and how it works?

orginally iota is wrongly used. after this PR SQL mode bits are aligned with https://github.com/mysql/mysql-server/blob/7d10c82196c8e45554f27c00681474a9fb86d137/sql/system_variables.h#L99 or https://dev.mysql.com/doc/internals/en/query-event.html#q-sql-mode-code

Check List

Tests

  • Unit test
  • Manual test (manually check)

Code changes

  • Has exported variable/fields change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note:
    fix wrong SQL mode constants

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lance6716
Copy link
Contributor Author

PTAL @bobotu @AilinKid

@lance6716 lance6716 mentioned this pull request Sep 4, 2020
Merged
AilinKid
AilinKid reviewed Sep 4, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGT1 label Sep 4, 2020
@zier-one
Copy link
Contributor

zier-one commented Sep 4, 2020

/lgtm

@ti-srebot
Copy link
Contributor

@leoppro,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: ddl(slack).

@lance6716
Copy link
Contributor Author

/run-all-tests

@wjhuang2016 wjhuang2016 closed this Sep 4, 2020
@wjhuang2016 wjhuang2016 reopened this Sep 4, 2020
wjhuang2016
wjhuang2016 reviewed Sep 4, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGT1 label Sep 4, 2020
@ti-srebot ti-srebot added the status/LGT2 LGT2 label Sep 4, 2020
@lance6716 lance6716 closed this Sep 4, 2020
@lance6716 lance6716 reopened this Sep 4, 2020
@kennytm
Copy link
Contributor

kennytm commented Sep 4, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@lance6716 lance6716 closed this Sep 4, 2020
@lance6716 lance6716 reopened this Sep 4, 2020
@kennytm
Copy link
Contributor

kennytm commented Sep 4, 2020

/run-all-tests

@lance6716 lance6716 closed this Sep 4, 2020
@lance6716 lance6716 reopened this Sep 4, 2020
@wjhuang2016 wjhuang2016 closed this Sep 4, 2020
@wjhuang2016 wjhuang2016 reopened this Sep 4, 2020
@lance6716 lance6716 mentioned this pull request Sep 4, 2020
Closed
@lance6716 lance6716 merged commit 5f138da into pingcap:master Sep 4, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 failed

@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 failed

tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@lance6716
const: fix wrong SQL mode const (pingcap#1008)
c24f8b1 
* const: fix wrong SQL mode const

* add test

* remove some change

* trigger CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
status/can-merge status/LGT2 LGT2 type/bug-fix fix bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lance6716 @CLAassistant @zier-one @ti-srebot @kennytm @AilinKid @wjhuang2016