Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support APPROX_PERCENTILE function (#1002) #1009

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Support APPROX_PERCENTILE function (#1002) #1009

merged 2 commits into from
Sep 4, 2020

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Sep 4, 2020

What problem does this PR solve?

Support parsing APPROX_PERCENTILE function. pingcap/tidb#19405

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Add function

Related changes

  • Need to cherry-pick to the release branch

kennytm
kennytm reviewed Sep 4, 2020
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 LGT1 label Sep 4, 2020
@ti-srebot ti-srebot removed the status/LGT1 LGT1 label Sep 4, 2020
@ti-srebot ti-srebot added the status/LGT2 LGT2 label Sep 4, 2020
@tangenta tangenta merged commit b17bc9b into pingcap:release-4.0 Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@tangenta tangenta tangenta approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
status/LGT2 LGT2 type/cherry-pick-for-release-4.0 type/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leiysky @kennytm @tangenta @ti-srebot