Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize and generate digest at same time (#215) #279

Merged
merged 2 commits into from
Apr 10, 2019
Merged

normalize and generate digest at same time (#215) #279

merged 2 commits into from
Apr 10, 2019

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Apr 9, 2019 •
edited
Loading

cherry-pick #215 to 2.1

This change is Reviewable

@lysu
normalize and generate digest at same time (#215)
2951399 
# Conflicts:
#	digester.go
#	digester_test.go
@lysu lysu requested review from jackysp and crazycs520 April 9, 2019 14:30
@lysu lysu mentioned this pull request Apr 10, 2019
Merged
crazycs520
crazycs520 reviewed Apr 10, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Apr 10, 2019
jackysp
jackysp approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit 3dd867e into pingcap:release-2.1 Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
status/LGT1 LGT1 type/cherry-pick-for-release-2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysu @jackysp @crazycs520 @kennytm