Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support syntax for 'admin reload expr_pushdown_blacklist' #350

Merged
merged 2 commits into from
Jun 12, 2019

Conversation

XuHuaiyu
Copy link
Contributor

What problem does this PR solve?

Support syntax for 'admin reload expr_pushdown_blacklist', which is used to reload the data of system table mysql.expr_pushdown_blacklist.

What is changed and how it works?

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

N/A

Related changes

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #350 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
- Coverage   52.68%   52.67%   -0.02%     
==========================================
  Files          31       31              
  Lines        6626     6628       +2     
==========================================
  Hits         3491     3491              
- Misses       2793     2795       +2     
  Partials      342      342
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
misc.go 96.42% <ø> (ø) ⬆️
ast/misc.go 18.26% <0%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea1bf0...c4f310a. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #350 into master will increase coverage by 1.82%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
+ Coverage   50.84%   52.67%   +1.82%     
==========================================
  Files          31       31              
  Lines        6864     6628     -236     
==========================================
+ Hits         3490     3491       +1     
+ Misses       3025     2795     -230     
+ Partials      349      342       -7
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
misc.go 96.42% <ø> (ø) ⬆️
ast/misc.go 18.26% <0%> (-0.04%) ⬇️
model/model.go 34.78% <0%> (+0.49%) ⬆️
terror/terror.go 72.95% <0%> (+1.17%) ⬆️
yy_parser.go 84.67% <0%> (+1.61%) ⬆️
ast/ddl.go 53.09% <0%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939965d...b2b647f. Read the comment docs.

@XuHuaiyu
Copy link
Contributor Author

related-PR: pingcap/tidb#10688

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 LGT1 label Jun 11, 2019
parser.y Show resolved Hide resolved
@XuHuaiyu XuHuaiyu requested a review from zz-jason June 12, 2019 03:35
zz-jason
zz-jason previously approved these changes Jun 12, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants