Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support where in admin show ddl statement #568

Merged
merged 3 commits into from
Oct 11, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

mysql>admin show ddl jobs where job_type='create table'
+--------+---------+------------+--------------+--------------+-----------+----------+-----------+-----------------------------------+-----------------------------------+--------+
| JOB_ID | DB_NAME | TABLE_NAME | JOB_TYPE     | SCHEMA_STATE | SCHEMA_ID | TABLE_ID | ROW_COUNT | START_TIME                        | END_TIME                          | STATE  |
+--------+---------+------------+--------------+--------------+-----------+----------+-----------+-----------------------------------+-----------------------------------+--------+
| 136    | test    | t          | create table | public       | 1         | 135      | 0         | 2019-09-29 17:41:40.561 +0800 CST | 2019-09-29 17:41:40.565 +0800 CST | synced |
+--------+---------+------------+--------------+--------------+-----------+----------+-----------+-----------------------------------+-----------------------------------+--------+

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Sep 29, 2019
zimulala
zimulala previously approved these changes Sep 29, 2019
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Oct 8, 2019
@crazycs520 crazycs520 merged commit 7586d61 into pingcap:master Oct 11, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 LGT2 type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants