Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up error code and message for parser #618

Merged
merged 1 commit into from
Nov 7, 2019
Merged

clean up error code and message for parser #618

merged 1 commit into from
Nov 7, 2019

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Nov 7, 2019

What problem does this PR solve?

following pingcap/tidb#12866 in the parser

What is changed and how it works?

clean up error code and message for the parser in yy_parser.go

remove unnecessary const code define

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • remove code

Side effects

  • n/a

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

@lysu lysu requested review from a team, imtbkcat and jackysp November 7, 2019 06:04
@ghost ghost requested review from tangenta and removed request for a team November 7, 2019 06:05
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 LGT1 label Nov 7, 2019
@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #618 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   79.77%   79.77%           
=======================================
  Files          32       32           
  Lines       12578    12578           
=======================================
  Hits        10034    10034           
  Misses       1948     1948           
  Partials      596      596
Impacted Files Coverage Δ
charset/charset.go 87.01% <ø> (ø) ⬆️
types/etc.go 89.47% <ø> (ø) ⬆️
yy_parser.go 83.46% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afbd9b8...89761bd. Read the comment docs.

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta merged commit 77c1f2c into pingcap:master Nov 7, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants