Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ast/functions: add tidb_decode_plan() function (#557) #629

Merged
merged 2 commits into from
Nov 8, 2019
Merged

ast/functions: add tidb_decode_plan() function (#557) #629

merged 2 commits into from
Nov 8, 2019

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Nov 8, 2019

What problem does this PR solve?

cherry-pick #557

@codecov
Copy link

codecov bot commented Nov 8, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-3.1@0c4055e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-3.1     #629   +/-   ##
==============================================
  Coverage               ?   51.27%           
==============================================
  Files                  ?       31           
  Lines                  ?     6888           
  Branches               ?        0           
==============================================
  Hits                   ?     3532           
  Misses                 ?     3006           
  Partials               ?      350
Impacted Files Coverage Δ
ast/functions.go 70.56% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c4055e...d77f776. Read the comment docs.

@bb7133 bb7133 mentioned this pull request Nov 8, 2019
Merged
zimulala
zimulala reviewed Nov 8, 2019
View reviewed changes
parser_test.go Outdated Show resolved Hide resolved
AilinKid
AilinKid reviewed Nov 8, 2019
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Nov 8, 2019
kennytm
kennytm approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm
Copy link
Contributor

kennytm commented Nov 8, 2019

(Refresh CLA)

@kennytm kennytm closed this Nov 8, 2019
@kennytm kennytm reopened this Nov 8, 2019
@kennytm kennytm added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Nov 8, 2019
@kennytm kennytm merged commit a8f0a51 into pingcap:release-3.1 Nov 8, 2019
@bb7133 bb7133 deleted the cp-557-3.1 branch December 5, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@AilinKid AilinKid AilinKid left review comments

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
status/LGT2 LGT2 type/cherry-pick-for-release-3.1 type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bb7133 @kennytm @zimulala @AilinKid @crazycs520