Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ast: support explain format hint #654

Merged
merged 2 commits into from
Dec 2, 2019
Merged

ast: support explain format hint #654

merged 2 commits into from
Dec 2, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Dec 2, 2019

What problem does this PR solve?

Support new format for explain.
For pingcap/tidb#13851

What is changed and how it works?

Define a new format hint for explain.

Check List

Tests

  • Unit test

Code changes

  • None

Side effects

  • None

Related changes

  • None

@alivxxx alivxxx requested review from eurekaka, winoros, lzmhhh123 and a team December 2, 2019 09:40
@ghost ghost requested review from kennytm and removed request for a team December 2, 2019 09:40
kennytm
kennytm reviewed Dec 2, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Dec 2, 2019
winoros
winoros approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Dec 2, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@12d98d3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #654   +/-   ##
=========================================
  Coverage          ?   80.01%           
=========================================
  Files             ?       32           
  Lines             ?    12703           
  Branches          ?        0           
=========================================
  Hits              ?    10164           
  Misses            ?     1935           
  Partials          ?      604
Impacted Files Coverage Δ
ast/misc.go 75.9% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d98d3...fd11e83. Read the comment docs.

@kennytm kennytm added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Dec 2, 2019
@alivxxx alivxxx merged commit 54fe742 into pingcap:master Dec 2, 2019
@alivxxx alivxxx deleted the hint branch December 2, 2019 10:39
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@alivxxx
ast: support explain format hint (pingcap#654)
5625f98
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@alivxxx
ast: support explain format hint (pingcap#654)
de04fa7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@winoros winoros winoros approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees
No one assigned
Labels
status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alivxxx @kennytm @winoros