support gbk charset #808
Open
support gbk charset #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #808 +/- ##
==========================================
- Coverage 78.35% 78.27% -0.09%
==========================================
Files 40 40
Lines 14773 14707 -66
==========================================
- Hits 11576 11512 -64
- Misses 2509 2515 +6
+ Partials 688 680 -8 |
kennytm
reviewed
Apr 13, 2020
Co-Authored-By: kennytm <kennytm@gmail.com>
@kennytm Because we just met |
tangenta
changed the title
|
PTAL @bb7133 @wjhuang2016 |
tangenta
reviewed
Apr 20, 2020
tangenta
added a commit
to tangenta/tidb
that referenced
this pull request
Apr 20, 2020
wjhuang2016
reviewed
Apr 20, 2020
Co-Authored-By: tangenta <tangenta@126.com>
|
@wjhuang2016 PTAL :) |
|
@spongedu: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
We're using parser to develop some our systems and found that charset gbk is not supported yet in parser, which makes some SQL fail to work.
As a MySQL compatible parser, I think we should support gbk as MySQL's parser do, and leave the charset-compatible issues to
TiDBlayer.What is changed and how it works?
Add gbk into supported charsets, and add related tests
Check List
Tests