Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more fields in DiffSchema for exchanging partition #883

Merged
merged 18 commits into from
Jun 9, 2020
Merged

Add more fields in DiffSchema for exchanging partition #883

merged 18 commits into from
Jun 9, 2020

Conversation

zhaox1n
Copy link
Contributor

@zhaox1n zhaox1n commented Jun 2, 2020 •
edited
Loading

What problem does this PR solve?

While exchanging partition affects 2 tables, we need to expand DiffSchema. Related PR in TIDB #17149

What is changed and how it works?

Check List

Tests

  • No code

Side effects

  • Increased code complexity

Release note

  • No release note

@codecov
Copy link

codecov bot commented Jun 2, 2020 •
edited
Loading

Codecov Report

Merging #883 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
- Coverage   78.32%   78.29%   -0.03%     
==========================================
  Files          40       40              
  Lines       14708    14700       -8     
==========================================
- Hits        11520    11510      -10     
- Misses       2505     2507       +2     
  Partials      683      683

@zhaox1n zhaox1n changed the title Add more fields in DiffSchem for exchanging partition Add more fields in DiffSchema for exchanging partition Jun 2, 2020
tiancaiamao
tiancaiamao reviewed Jun 2, 2020
View reviewed changes
model/ddl.go Outdated Show resolved Hide resolved
@tiancaiamao tiancaiamao mentioned this pull request Jun 3, 2020
Merged
zimulala
zimulala reviewed Jun 4, 2020
View reviewed changes
model/ddl.go Outdated Show resolved Hide resolved
@zhaox1n @zimulala
Update model/ddl.go
a36e536 
Co-authored-by: Lynn <zimu_xia@126.com>
kennytm
kennytm reviewed Jun 4, 2020
View reviewed changes
model/ddl.go Outdated Show resolved Hide resolved
zhaox1n and others added 3 commits June 4, 2020 14:48
@zhaox1n @kennytm
Update model/ddl.go
985e550 
Co-authored-by: kennytm <kennytm@gmail.com>
@zhaox1n
rename
3ff6921
@zhaox1n
rename
11a8459
zimulala
zimulala reviewed Jun 5, 2020
View reviewed changes
model/ddl.go Outdated Show resolved Hide resolved
model/ddl.go Outdated Show resolved Hide resolved
zimulala
zimulala reviewed Jun 8, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala
Copy link
Contributor

zimulala commented Jun 8, 2020

PTAL @tiancaiamao @kennytm

zimulala
zimulala reviewed Jun 8, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, maybe we need to add a field to BinlogInfo.

zimulala
zimulala reviewed Jun 8, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, maybe we need to add a field to BinlogInfo.

Confirmed with classmates of drainer and CDC, no new fields need to be added at present.

@zimulala zimulala added the status/LGT1 LGT1 label Jun 8, 2020
kennytm
kennytm approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm removed the status/LGT1 LGT1 label Jun 8, 2020
@kennytm kennytm added the status/LGT2 LGT2 label Jun 8, 2020
@tiancaiamao
Copy link
Collaborator

LGTM

@tiancaiamao tiancaiamao merged commit ebf3b6e into pingcap:master Jun 9, 2020
tiancaiamao added a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@zhaox1n @zimulala
@kennytm @tiancaiamao
Add more fields in DiffSchema for exchanging partition (pingcap#883)
285101c 
Co-authored-by: Lynn <zimu_xia@126.com>
Co-authored-by: kennytm <kennytm@gmail.com>
Co-authored-by: tiancaiamao <tiancaiamao@gmail.com>
@bb7133 bb7133 mentioned this pull request Aug 8, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@kennytm kennytm kennytm approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhaox1n @zimulala @tiancaiamao @kennytm