parser: add new agg function APPROX_COUNT_DISTINCT (#854)
#906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release-4.0 #906 +/- ##
===============================================
+ Coverage 78.25% 78.29% +0.04%
===============================================
Files 40 40
Lines 14710 14788 +78
===============================================
+ Hits 11511 11579 +68
- Misses 2519 2524 +5
- Partials 680 685 +5 |
XuHuaiyu
reviewed
Jun 18, 2020
| @@ -6384,6 +6387,10 @@ SumExpr: | |||
| $$ = &ast.AggregateFuncExpr{F: $1, Args: args} | |||
| } | |||
| } | |||
| | builtinApproxCountDistinct '(' ExpressionList ')' | |||
| { | |||
| $$ = &ast.AggregateFuncExpr{F: $1, Args: $3.([]ast.ExprNode), Distinct: false} | |||
There was a problem hiding this comment.
Distinct: false can be removed?
There was a problem hiding this comment.
Maybe other logic use this field.
kennytm
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #854 to release-4.0
What problem does this PR solve?
What is changed and how it works?
Add new agg function
APPROX_COUNT_DISTINCTto compute approximate result like count distinct.executor: add new agg function
APPROX_COUNT_DISTINCTtidb#17175Check List
Tests