pump/: Add syn-log option #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
july2993
added
status/WIP
status/DNM
status/LGT1
status/PTAL
and removed
status/WIP
status/DNM
status/LGT1
labels
|
@GregoryIan PTAL |
suzaku
reviewed
Mar 29, 2019
IANTHEREAL
reviewed
Mar 29, 2019
|
/run-all-tests |
|
LGTM |
|
/run-unit-test |
suzaku
reviewed
Mar 29, 2019
| @@ -64,7 +64,7 @@ type Config struct { | |||
| configFile string | |||
| printVersion bool | |||
| tls *tls.Config | |||
| Storage *storage.Config `toml:"storage" json:"storage"` | |||
| Storage storage.Config `toml:"storage" json:"storage"` | |||
There was a problem hiding this comment.
What do we get when this is changed from pointer to value?
There was a problem hiding this comment.
just no need to check if Storage is nil (when no Storage** is config in file)
suzaku
reviewed
Mar 29, 2019
| } | ||
|
|
||
| // GetSyncLog return sync-log config option | ||
| func (c *Config) GetSyncLog() bool { |
There was a problem hiding this comment.
We could also handle the nil value in options.WithSync so that:
- the other callers also don't have to worry about
nils - we can use
config.SyncLoglike when we are accessing the other config values
There was a problem hiding this comment.
WithSync accept bool not *bool, and if accept *bool if pass nil seems meaningless.
|
LGTM |
IANTHEREAL
approved these changes
Mar 29, 2019
july2993
added a commit
that referenced
this pull request
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
add syn-log config option see pump.toml change
What is changed and how it works?
add syn-log config
change template compaction-total-size-multiplier from
8->8.0which should be floatCheck List
Tests
check config work by log
Code changes
Side effects
Related changes