reparo/syncer: add unit test #540
Conversation
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
|
/run-all-tests |
|
/run-unit-test |
|
can you separate the bug fix into another pr? |
|
|
||
| var _ = check.Suite(&testPrintSuite{}) | ||
|
|
||
| func (s *testPrintSuite) TestPrintSyncer(c *check.C) { |
There was a problem hiding this comment.
It seems that these test cases are almost identical, can we create a test function that can validate all of these syncers?
There was a problem hiding this comment.
only validation functions are different
There was a problem hiding this comment.
and this case is lack of output validation
There was a problem hiding this comment.
define a new function to do these things 201a7cb
|
where is the bug? 🤔 |
| if err != nil { | ||
| return nil, errors.Trace(err) | ||
| } | ||
| _, oldDatum, err := codec.DecodeOne(col.ChangedValue) | ||
| _, newDatum, err := codec.DecodeOne(col.ChangedValue) |
reparo/syncer/mysql_test.go
Outdated
| dmlBinlog := &pb.Binlog{ | ||
| Tp: pb.BinlogType_DML, | ||
| DmlData: &pb.DMLData{ | ||
| Events: generateDMLEvents(c)[0:1], |
There was a problem hiding this comment.
test two case Events: generateDMLEvents(c)[0:2],?
|
Rest LGTM |
|
/run-all-tests |
|
LGTM |
|
/run-all-tests |
|
LGTM |
What problem does this PR solve?
add unit test for reparo/syncer
https://internal.pingcap.net/jira/browse/TOOL-1057
What is changed and how it works?
Check List
Tests
Related changes