pump/*: Refine some log in storage/ #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/rebuild |
suzaku
reviewed
May 20, 2019
|
/run-all-tests |
|
LGTM |
IANTHEREAL
reviewed
May 20, 2019
IANTHEREAL
reviewed
May 20, 2019
IANTHEREAL
reviewed
May 20, 2019
IANTHEREAL
reviewed
May 20, 2019
Co-Authored-By: Ian <ArGregoryIan@gmail.com>
Co-Authored-By: Ian <ArGregoryIan@gmail.com>
Co-Authored-By: Ian <ArGregoryIan@gmail.com>
|
/run-all-tests |
|
/run-all-tests |
IANTHEREAL
reviewed
May 20, 2019
pump/storage/vlog.go
Outdated
| @@ -305,7 +304,7 @@ func (vlog *valueLog) write(reqs []*request) error { | |||
| if vlog.sync { | |||
| err = curFile.fdatasync() | |||
| if err != nil { | |||
| return errors.Trace(err) | |||
| return errors.Annotate(err, "fdatasync failed") | |||
There was a problem hiding this comment.
should we add file name?
Co-Authored-By: Ian <ArGregoryIan@gmail.com>
Co-Authored-By: Ian <ArGregoryIan@gmail.com>
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
LGTM |
IANTHEREAL
approved these changes
May 20, 2019
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests tidb=release-2.1 tikv=release-2.1 pd=release-2.1 |
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
May 23, 2019
IANTHEREAL
pushed a commit
that referenced
this pull request
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Refine some log in storage/
What is changed and how it works?
RT
Check List
Tests
Code changes
Side effects
Related changes