Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support tls in tidb-ctl #26

Merged
merged 2 commits into from
Mar 10, 2020
Merged

support tls in tidb-ctl #26

merged 2 commits into from
Mar 10, 2020

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Mar 10, 2020

ref pingcap/tidb#15173

make tidb-ctl support tls if give 'ssl-cart', 'ssl-key', 'ca'

./tidb-ctl schema --ssl-cert /home/robi/tmplog/ccc/client.pem --ssl-key /home/robi/tmplog/ccc/client-key.pem --ca /home/robi/tmplog/ccc/ca.pem 
[
    {
        "id": 4611686018427397904,
        "db_name": {
            "O": "PERFORMANCE_SCHEMA",
            "L": "performance_schema"
        },
        "charset": "utf8mb4",
        "collate": "utf8mb4_bin",
        "state": 0
    },
    {
        "id": 1,
        "db_name": {
            "O": "test",
            "L": "test"
        },
        "charset": "utf8mb4",
        "collate": "utf8mb4_bin",
        "state": 5
    },
    {
        "id": 3,
        "db_name": {
            "O": "mysql",
            "L": "mysql"
        },
        "charset": "utf8mb4",
        "collate": "utf8mb4_bin",
        "state": 5
    },
    {
        "id": 4611686018427387905,
        "db_name": {
            "O": "INFORMATION_SCHEMA",
            "L": "information_schema"
        },
        "charset": "utf8mb4",
        "collate": "utf8mb4_bin",
        "state": 0
    },
    {
        "id": 4611686018427417904,
        "db_name": {
            "O": "INSPECTION_SCHEMA",
            "L": "inspection_schema"
        },
        "charset": "utf8mb4",
        "collate": "utf8mb4_bin",
        "state": 0
    },
    {
        "id": 4611686018427407904,
        "db_name": {
            "O": "METRICS_SCHEMA",
            "L": "metrics_schema"
        },
        "charset": "utf8mb4",
        "collate": "utf8mb4_bin",
        "state": 0
    }
]

This change is Reviewable

@lysu lysu requested review from jackysp and imtbkcat March 10, 2020 09:01
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants