Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff tikv tiflash #834

Merged
merged 5 commits into from
Jan 4, 2021
Merged

Diff tikv tiflash #834

merged 5 commits into from
Jan 4, 2021

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Dec 31, 2020

close issue #833

What did:

  • Differ TiFlash and TiKV nodes by different text and color (maybe we can choose a better color)
  • Make reload really work
  • Change tooltip to the text which always shows

Effect:

WeCom20201231-161953@2x

@baurine
Copy link
Collaborator Author

baurine commented Dec 31, 2020

@breeswish @unbyte PTAL, thanks!

@unbyte
Copy link
Contributor

unbyte commented Dec 31, 2020

color differences between nodes doesn't seem to be obvious. how about changing edge color too?

@breezewish
Copy link
Member

color differences between nodes doesn't seem to be obvious. how about changing edge color too?

+1. And maybe color can be changed as well, for example, a color which has more contrast:

Magenta-4

image

or Volcano-4

image

@baurine
Copy link
Collaborator Author

baurine commented Jan 4, 2021 •
edited
Loading

How about this? The colors are cyan[5], magenta[5] and orange[5].

image

breezewish
breezewish approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Just a guess. Maybe you can try with:

Line/Label: gray[5] / gray[4]
TiKV: cyan[5]
TiFlash: magenta[4]

The color display may be better. Current TiKV / TiFlash colors seems to be a bit dark.

@baurine
Copy link
Collaborator Author

baurine commented Jan 4, 2021

Update colors by:

Line/Label: #ddd / grey[1]
TiKV: cyan[5]
TiFlash: magenta[4]

image

@baurine baurine merged commit 2592c42 into pingcap:master Jan 4, 2021
@baurine baurine deleted the diff-tikv-tiflash branch January 4, 2021 09:09
breezewish pushed a commit that referenced this pull request Jan 4, 2021
@baurine @breezewish
differ tikv and tiflash nodes (#834)
583533e
breezewish added a commit that referenced this pull request Jan 4, 2021
@breezewish
Release v2021.01.04.1 (#837)
41a0a3a 
* ui: increasing precision for metric chart y axis (#823)
* build(deps): bump ini from 1.3.5 to 1.3.8 in /ui (#824)
* build(deps): bump ini from 1.3.5 to 1.3.8 in /ui/tests (#825)
* Upgrade antd (#811)
* Upgrade ahooks (#814)
* fix issue of query topn statement get error (#827)
* ui: show indents for slow query detail time more elegantly (#830)
* differ tikv and tiflash nodes (#834)
* Release v2021.01.04.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

Assignees
No one assigned
Labels
status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baurine @unbyte @breezewish @ti-chi-bot