This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
mydump,restore: reduce parser memory allocation #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
|
/run-all-tests |
|
/run-integration-test |
|
/run-all-tests |
|
/run-integration-test |
lonng
added
status/PTAL
kennytm
added
status/LGT1
|
@july2993 @GregoryIan PTAL |
IANTHEREAL
reviewed
Dec 24, 2018
IANTHEREAL
reviewed
Dec 24, 2018
| switch err { | ||
| case io.ErrUnexpectedEOF, io.EOF: | ||
| parser.isLastChunk = true | ||
| fallthrough | ||
| case nil: | ||
| tryAppendTo(&parser.buf, block[:n]) | ||
| parser.remainBuf.Reset() |
There was a problem hiding this comment.
can we omit remainBuf?
There was a problem hiding this comment.
Can not, because of parser.buf reference to appendBuf.Bytes()
There was a problem hiding this comment.
leave a comment above code
|
LGTM |
IANTHEREAL
added
status/LGT2
lonng
force-pushed
the
lonng/pr-parser-mem
branch
from
f2521f1
to
c3ba4ad
Compare
ngaut
reviewed
Dec 25, 2018
| @@ -1386,7 +1387,7 @@ func (cr *chunkRestore) restore( | |||
|
|
|||
| // sql -> kv | |||
| start = time.Now() | |||
| kvs, _, err := kvEncoder.SQL2KV(buffer.String()) | |||
| kvs, _, err := kvEncoder.SQL2KV(hack.String(buffer.Bytes())) | |||
There was a problem hiding this comment.
We should change the argument type of SQL2KV from string to byte slice. You should not use hack package usually.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Reduce parser memory allocation
Benchmark (SQL file: 1529669bytes ~1.5MB, Chunk size: 64KB, Rows: 223):
Previous benchmark ref: #107,
BenchmarkChunkRestoreReuseBuffer3is the latest version.What is changed and how it works?
Add blockBuf to parser
Check List
Tests
Code changes
Side effects
Related changes