This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 66
*: parse the data source directly into data and skip the KV encoder #145
Merged
Commits on Mar 23, 2019
-
*: parse the data source directly into data and skip the KV encoder
This skips the more complex pingcap/parser, and speeds up parsing speed by 50%. We have also refactored the KV delivery mechanism to use channels directly, and revamped metrics: - Make the metrics about engines into its own `engines` counter. The `tables` counter is exclusively about tables now. - Removed `block_read_seconds`, `block_read_bytes`, `block_encode_seconds` since the concept of "block" no longer applies. Replaced by the equivalents named `row_***`. - Removed `chunk_parser_read_row_seconds` for being overlapping with `row_read_seconds`. - Changed `block_deliver_bytes` into a histogram vec, with kind=index or kind=data. Introduced `block_deliver_kv_pairs`.
Configuration menu - View commit details
-
Copy full SHA for b00ba33 - Browse repository at this point
Copy the full SHA b00ba33View commit details -
tests,restore: prevent spurious error in checkpoint_chunks test
Only kill Lightning if the whole chunk is imported exactly. The chunk checkpoint may be recorded before a chunk is fully written, and this will hit the failpoint more than 5 times.
Configuration menu - View commit details
-
Copy full SHA for 27f5be8 - Browse repository at this point
Copy the full SHA 27f5be8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b645921 - Browse repository at this point
Copy the full SHA b645921View commit details -
Configuration menu - View commit details
-
Copy full SHA for b15a293 - Browse repository at this point
Copy the full SHA b15a293View commit details -
common: disable IsContextCanceledError() when log level = debug
This helps debugging some mysterious cancellation where the log is inhibited. Added IsReallyContextCanceledError() for code logic affected by error type.
Configuration menu - View commit details
-
Copy full SHA for e17c94d - Browse repository at this point
Copy the full SHA e17c94dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91669db - Browse repository at this point
Copy the full SHA 91669dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a41fa4d - Browse repository at this point
Copy the full SHA a41fa4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6aa40ab - Browse repository at this point
Copy the full SHA 6aa40abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e86c78 - Browse repository at this point
Copy the full SHA 7e86c78View commit details
Commits on Mar 27, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 98e1c18 - Browse repository at this point
Copy the full SHA 98e1c18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27872b3 - Browse repository at this point
Copy the full SHA 27872b3View commit details
Commits on Apr 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for fa32cf7 - Browse repository at this point
Copy the full SHA fa32cf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c94bffa - Browse repository at this point
Copy the full SHA c94bffaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8edafc6 - Browse repository at this point
Copy the full SHA 8edafc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4bbacc - Browse repository at this point
Copy the full SHA b4bbaccView commit details
Commits on Apr 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 9e4f601 - Browse repository at this point
Copy the full SHA 9e4f601View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ada276 - Browse repository at this point
Copy the full SHA 0ada276View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.