Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

config: Allow overriding some config from command line #157

Merged
merged 5 commits into from
Apr 9, 2019
Merged

config: Allow overriding some config from command line #157

merged 5 commits into from
Apr 9, 2019

Conversation

kennytm
Copy link
Collaborator

@kennytm kennytm commented Mar 28, 2019 •
edited
Loading

What problem does this PR solve?

Addresses one part of #131, makes config.toml unnecessary.

What is changed and how it works?

Added the following flags:

  • -L
  • -d
  • --log-file
  • --tidb-host, --tidb-port, --tidb-user, --tidb-status
  • --pd-urls
  • --importer

Additionally, removed the following flags from tidb-lightning (use the corresponding flags from tidb-lightning-ctl instead):

  • --compact
  • --switch-mode

Check List

Tests

  • Integration test

Side effects

  • Breaking backward compatibility
    • unspecified --config now also searches conf/tidb-lightning.toml, and fallbacks to use the default config if the file cannot be found.
    • --compact and --switch-mode are removed.
    • This PR should not be cherry-picked to 2.1. Consider not merging it until 2.1.8 is frozen.

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@kennytm kennytm added status/PTAL This PR is ready for review. Add this label back after committing new changes priority/normal type/feature New feature labels Mar 28, 2019
amyangfei
amyangfei reviewed Mar 29, 2019
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added status/LGT1 One reviewer already commented LGTM (LGTM1) and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Mar 29, 2019
lonng
lonng approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng lonng added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels Mar 29, 2019
@kennytm kennytm merged commit 3f468b3 into master Apr 9, 2019
@kennytm kennytm mentioned this pull request Apr 17, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyangfei amyangfei amyangfei left review comments

@IANTHEREAL IANTHEREAL IANTHEREAL left review comments

@lonng lonng lonng approved these changes

Assignees
No one assigned
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennytm @amyangfei @lonng @IANTHEREAL