This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
tests: fix a test failure due to conflict between #145 and #158 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
status/PTAL
|
/run-all-tests |
|
PTAL @amyangfei @lonng |
amyangfei
reviewed
Apr 3, 2019
|
/run-all-tests |
|
LGTM |
lonng
added
status/LGT1
amyangfei
added
status/LGT2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix this failure https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/test_lightning_master/detail/test_lightning_master/25/pipeline
Problem was that #158 introduced a new test involving a failpoint which definition is changed in #145. There is no syntactical conflict between the two so the PRs merged cleanly, but the semantic conflict caused the integration test failure above.
What is changed and how it works?
Updated the failpoint definition.
Check List
Tests
Side effects
Related changes