This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
config: automatically discover tidb.pd-addr and tidb.port if not provided #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
status/PTAL
|
/run-all-tests |
IANTHEREAL
reviewed
Apr 28, 2019
IANTHEREAL
reviewed
Apr 28, 2019
IANTHEREAL
reviewed
Apr 28, 2019
|
Rest LGTM |
|
/run-all-tests tidb=master tikv=master pd=master |
TiDB team says it is useless and TiDB won't work with port-forwarding.
|
LGTM |
kennytm
added
status/LGT1
|
@kennytm Please resolve the conflicts |
|
PTAL @lonng |
kennytm
added
status/LGT2
|
/run-all-tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Part of #131.
The setting
tidb.portandtidb.pd-addrcan be automatically discovered through the status API, allowing these to be omitted while Lightning could still obtain the correct values.What is changed and how it works?
Change the default values of
tidb.portfrom 4000 to 0 andtidb.pd-addrfrom "127.0.0.1:2379" to "".If these values are empty, reach for
http://{tidb.host}:{tidb.status-port}/settings, and use these settings instead.Check List
Tests
Side effects
Related changes