Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

restore: retry if deliver KVs to importer #176

Merged
merged 8 commits into from
May 8, 2019
Merged

restore: retry if deliver KVs to importer #176

merged 8 commits into from
May 8, 2019

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Apr 29, 2019 •
edited
Loading

Signed-off-by: Lonng chris@lonng.org

What problem does this PR solve? 

2019/04/28 07:50:23.039  [error] [`db1903_baofu`.`cm_entry`:11] [/data1/hybrid/baofu/db1903_baofu.cm_entry.3771.sql:0] error EOF
2019/04/28 07:50:23.039  [info] [`db1903_baofu`.`cm_entry`:11] encode kv data and write takes 1m11.606816959s (read 22382456589, written 392441556)
2019/04/28 07:50:23.039  [error] [`db1903_baofu`.`cm_entry`:11] error EOF

What is changed and how it works?

Retry if deliver KVs to the importer failed.

Check List

Tests

  • Unit test
  • Integration test

Side effects

Related changes

@lonng
restore: retry if deliver KVs to importer
6999421 
Signed-off-by: Lonng <chris@lonng.org>
@lonng lonng added the status/DNM Do not merge, test is failing or blocked by another PR label Apr 29, 2019
@lonng
Copy link
Contributor Author

lonng commented Apr 30, 2019

/rebuild

@lonng lonng added priority/normal Should Cherry-pick This PR should be cherry-picked back the previous release train status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/DNM Do not merge, test is failing or blocked by another PR labels May 6, 2019
@lonng
Copy link
Contributor Author

lonng commented May 6, 2019

/run-all-tests

@lonng
Copy link
Contributor Author

lonng commented May 6, 2019

/run-all-tests

@lonng
Copy link
Contributor Author

lonng commented May 6, 2019

@kennytm @july2993 PTAL

@kennytm
Copy link
Collaborator

kennytm commented May 8, 2019

/run-all-tests

kennytm
kennytm reviewed May 8, 2019
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT1 One reviewer already commented LGTM (LGTM1) and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels May 8, 2019
july2993
july2993 reviewed May 8, 2019
View reviewed changes
Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels May 8, 2019
@lonng lonng merged commit dd21072 into master May 8, 2019
@lonng lonng deleted the lonng/retry-deliver branch May 8, 2019 03:06
kennytm pushed a commit that referenced this pull request May 8, 2019
@lonng @kennytm
restore: retry if deliver KVs to importer (#176)
dffcac3
@kennytm kennytm removed the Should Cherry-pick This PR should be cherry-picked back the previous release train label May 8, 2019
@kennytm kennytm mentioned this pull request May 8, 2019
Merged
kennytm pushed a commit that referenced this pull request May 8, 2019
@lonng @kennytm
restore: retry if deliver KVs to importer (#176)
ec30c02
lonng pushed a commit that referenced this pull request May 9, 2019
@kennytm @lonng
[2.1] Cherry-pick #176 and #179 (#184)
4d803b8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm left review comments

@july2993 july2993 july2993 approved these changes

Assignees
No one assigned
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lonng @kennytm @july2993