Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

backend: fix issue 282 #283

Merged
merged 6 commits into from
Mar 16, 2020
Merged

backend: fix issue 282 #283

merged 6 commits into from
Mar 16, 2020

Conversation

kennytm
Copy link
Collaborator

@kennytm kennytm commented Mar 16, 2020 •
edited
Loading

What problem does this PR solve?

Fixed #282, caused by a typo.

What is changed and how it works?

Previously \Z was treated as \x26 (which is &). It should be \x1a (decimal 26).

Check List

Tests

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note
    • fixed the bug where the characters & is replaced by EOF character in TiDB backend.
    • fixed the bug where \Z is replaced by &.

@kennytm kennytm added status/WIP Work in progress priority/important type/bug-fix Bug fix 3.0-release-note Should include in release note for next 3.0 release. Remove after release. 3.1-release-note Should include in release note for next 3.1 release. Remove after release. 4.0-release-note Should include in release note for next 4.0 release. Remove after release. labels Mar 16, 2020
@kennytm kennytm added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP Work in progress labels Mar 16, 2020
@kennytm
Copy link
Collaborator Author

kennytm commented Mar 16, 2020

/run-all-tests

@IANTHEREAL
Copy link
Collaborator

LGTM

@IANTHEREAL IANTHEREAL added status/LGT1 One reviewer already commented LGTM (LGTM1) and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Mar 16, 2020
@kennytm
Copy link
Collaborator Author

kennytm commented Mar 16, 2020

PTAL @leoppro

zier-one
zier-one approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm merged commit 0f54c30 into master Mar 16, 2020
@kennytm kennytm deleted the kennytm/fix-282 branch March 16, 2020 12:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zier-one zier-one zier-one approved these changes

Assignees
No one assigned
Labels
3.0-release-note Should include in release note for next 3.0 release. Remove after release. 3.1-release-note Should include in release note for next 3.1 release. Remove after release. 4.0-release-note Should include in release note for next 4.0 release. Remove after release. status/LGT1 One reviewer already commented LGTM (LGTM1) type/bug-fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: restore data by mistake in tidb backend mode
3 participants
@kennytm @IANTHEREAL @zier-one