This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
log: fix log file path #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3pointer
reviewed
Jul 7, 2020
lightning/config/global.go
Outdated
| @@ -197,6 +197,9 @@ func LoadGlobalConfig(args []string, extraFlags func(*flag.FlagSet)) (*GlobalCon | |||
| if *logFilePath != "" { | |||
| cfg.App.Config.File = *logFilePath | |||
| } | |||
| if cfg.App.Config.File == "" { | |||
There was a problem hiding this comment.
Suggested change
| if cfg.App.Config.File == "" { | |
| else { |
There was a problem hiding this comment.
This else is not ok, because toml config may set the log config path
kennytm
reviewed
Jul 7, 2020
Then I think we should leave the default to stdout |
|
We could make |
So shall we need to update docs for this special log config. Seems br special env |
kennytm
added
Should Update Ansible
lichunzhu
added
status/LGT2
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix lightning always set log file path to the default path
What is changed and how it works?
Only set log path to default path if neither command line params nor config file set it
Check List
Tests
Side effects
Related changes