Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

Fix verbose log message for shell #352

Merged
merged 1 commit into from Jul 22, 2020
Merged

Fix verbose log message for shell #352

merged 1 commit into from Jul 22, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 17, 2020

What problem does this PR solve?

When I run a new tidb-lightning task interactively, it generates a log file for verbose output. In my shell I double-click to pickup that file so I can copy it. Unfortunately it has a trailing . which is annoying enough to me that you are seeing this PR :-)

What is changed and how it works?

Message text change

Check List

  • No code

Side effects

  • None

Related changes

  • None

@CLAassistant
Copy link

CLAassistant commented Jul 17, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nullnotnil please sign the CLA, thanks.

@kennytm kennytm added the status/LGT1 One reviewer already commented LGTM (LGTM1) label Jul 17, 2020
@ghost
Copy link
Author

ghost commented Jul 20, 2020

CLA signed.

Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@3pointer 3pointer added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels Jul 22, 2020
@3pointer 3pointer merged commit 32c2868 into pingcap:master Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants