This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
restore: don't switch mode in tidb backend #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
reviewed
Aug 11, 2020
lightning/restore/restore.go
Outdated
| @@ -460,15 +460,21 @@ func (rc *RestoreController) listenCheckpointUpdates() { | |||
| rc.checkpointsWg.Done() | |||
| } | |||
|
|
|||
| func (rc *RestoreController) runPeriodicActions(ctx context.Context, stop <-chan struct{}) { | |||
| switchModeTicker := time.NewTicker(rc.cfg.Cron.SwitchMode.Duration) | |||
| func (rc *RestoreController) runPeriodicActions(ctx context.Context, stop <-chan struct{}, shouldSwitchMode bool) { | |||
There was a problem hiding this comment.
i prefer removing the shouldSwitchMode parameter and check rc.cfg.TikvImporter.Backend inside this function
kennytm
added
status/LGT2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Do not switch tikv to importer mode in tidb backend
What is changed and how it works?
Check List
Tests
Side effects
Related changes