This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
post-restore: add optional level for post-restore operations #421
post-restore: add optional level for post-restore operations #421
Changes from 1 commit
d0e5ef6
fa6b183
c8e1bdc
218b1fe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think you can implement
UnmarshalText
this way. Thetext
can be"required"
or'required'
or"""""required"""""
. Better implementUnmarshalTOML
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a interface
UnmarshalTOML
in the toml or encoding package? The toml souce code show table it use theencoding.TextUnmarshaler
to decode?Shall we do a strings.Trim(text, `'"`) here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No
https://pkg.go.dev/github.com/BurntSushi/toml#example-package-UnmarshalTOML
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed