Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

backend/local: fallback retryIngest to retryWrite #554

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Jan 21, 2021

What problem does this PR solve?

Fallback retry ingest with retry write and ingest due to tikv/tikv#9496

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression

Related changes

@glorv
Copy link
Contributor Author

glorv commented Jan 21, 2021

@Little-Wallace @overvenus PTAL

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM (LGTM1) label Jan 22, 2021
@overvenus
Copy link
Member

/lgtm

@ti-srebot ti-srebot removed the status/LGT1 One reviewer already commented LGTM (LGTM1) label Jan 29, 2021
@ti-srebot ti-srebot added the status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) label Jan 29, 2021
@glorv
Copy link
Contributor Author

glorv commented Jan 29, 2021

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added status/LGT3 and removed status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) labels Jan 29, 2021
@ti-srebot ti-srebot merged commit c69c738 into master Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants