Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade k8s code to 1.16 #1020

Closed
cofyc opened this issue Oct 16, 2019 · 6 comments · Fixed by #1082
Closed

upgrade k8s code to 1.16 #1020

cofyc opened this issue Oct 16, 2019 · 6 comments · Fixed by #1082
Assignees

Comments

@cofyc
Copy link
Contributor

cofyc commented Oct 16, 2019

Feature Request

Is your feature request related to a problem? Please describe:

Keep up to date with the latest k8s code.

  • compatibility is guaranteed by CI and stability tests (tested in k8s 1.12.x), in the future, we can add more test jobs for other Kubernetes versions (e2e: test against multiple Kubernetes versions #1008)
  • latest k8s e2e framework (k8s.io/kubernetes/test/e2e/framework) is well designed and can be reused in projects outside of core Kubernetes, we can leverage this framework to write our e2e tests
  • easier to adopt libraries which depends on newer k8s code

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@cofyc
Copy link
Contributor Author

cofyc commented Oct 28, 2019

@yylt
Copy link

yylt commented Oct 29, 2019

the pingcap/pd not use go mod manage module at v2.1.0-beta+incompatible
pd use etcd@v0.0.0-20180530235116-2b3aa7e1d49d, but k8s@1.16 use etcd@v3.3.15 , it will conflict

@cofyc
Copy link
Contributor Author

cofyc commented Oct 29, 2019

yes, it's a problem, we need to upgrade PD

@cofyc cofyc self-assigned this Oct 29, 2019
@gregwebs
Copy link
Contributor

gregwebs commented Oct 29, 2019

PD should not be required to align dependencies with k8s, particularly one like etcd. We just need to reference some API code that should be abstracted over PD dependencies.
I think the problem is that we are referencing a PD package that imports many things. Instead the PD API definitions should be moved to a package with minimal dependencies.

@cofyc
Copy link
Contributor Author

cofyc commented Oct 29, 2019

I think the problem is that we are referencing a PD package that imports many things. Instead the PD API definitions should be moved to a package with minimal dependencies.

yes, that will be better

@aylei
Copy link
Contributor

aylei commented Oct 29, 2019

I think the problem is that we are referencing a PD package that imports many things. Instead the PD API definitions should be moved to a package with minimal dependencies.

@gregwebs I'm working on proposing this to PD and TiDB.

@cofyc Because it takes time for PD to merge the change and release a new version, I've copied the config type definition and get rid of the pd/server dependency for now in #1048

yahonda pushed a commit that referenced this issue Dec 27, 2021
* en: refactor monitoring docs

Signed-off-by: Ran <huangran@pingcap.com>

* add aliases

Signed-off-by: Ran <huangran@pingcap.com>

* fix deadlink

Signed-off-by: Ran <huangran@pingcap.com>

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants