Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install tidb-apiserver in tidb-operator chart #1083

Merged
merged 4 commits into from
Oct 31, 2019
Merged

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Oct 30, 2019

Signed-off-by: Aylei rayingecho@gmail.com

What problem does this PR solve?

Install tidb-apiserver in tidb-operator chart, this will make e2e tests of tidb-apiserver easier.

close #1060

What is changed and how does it work?

The related resources are added for tidb-apiserver. The CA cert/key and CA bundle have to be created manually. I will adopt a better cert management strategy that will be introduced in #1040 after #1040 get merged @Yisaer .

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Does this PR introduce a user-facing change?:

Add tidb-apiserver in tidb-operator chart

@cofyc @weekface @tennix @Yisaer PTAL

Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei aylei added status/PTAL PR needs to be reviewed area/api labels Oct 30, 2019
@aylei aylei added this to the v1.1.0 milestone Oct 30, 2019
@aylei
Copy link
Contributor Author

aylei commented Oct 31, 2019

/run-e2e-in-kind

1 similar comment
@aylei
Copy link
Contributor Author

aylei commented Oct 31, 2019

/run-e2e-in-kind

@aylei
Copy link
Contributor Author

aylei commented Oct 31, 2019

/run-e2e-in-kind

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei aylei merged commit 0b61a89 into pingcap:master Oct 31, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api status/PTAL PR needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install aggregated apiserver in the tidb-operator helm chart
3 participants