Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine logs for controller watcher #1493

Merged
merged 5 commits into from
Jan 9, 2020
Merged

refine logs for controller watcher #1493

merged 5 commits into from
Jan 9, 2020

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Jan 6, 2020

Signed-off-by: Aylei rayingecho@gmail.com

What problem does this PR solve?

close #1476

Does this PR introduce a user-facing change?:

Refine logs for `TidbMonitor` and `TidbInitializer` controller

Signed-off-by: Aylei <rayingecho@gmail.com>
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor Author

aylei commented Jan 6, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 6, 2020

Your auto merge job has been accepted, waiting for 1486, 1484

@sre-bot
Copy link
Contributor

sre-bot commented Jan 6, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 6, 2020

@aylei merge failed.

@aylei
Copy link
Contributor Author

aylei commented Jan 8, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 8, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 8, 2020

@aylei merge failed.

@aylei
Copy link
Contributor Author

aylei commented Jan 8, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 8, 2020

Your auto merge job has been accepted, waiting for 1486, 1466, 1405, 1501

@sre-bot
Copy link
Contributor

sre-bot commented Jan 8, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 8, 2020

@aylei merge failed.

@aylei
Copy link
Contributor Author

aylei commented Jan 9, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

Your auto merge job has been accepted, waiting for 1516, 1515, 1513

@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

/run-all-tests

@sre-bot sre-bot merged commit 1a203d8 into pingcap:master Jan 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

cherry pick to release-1.1 in PR #1524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error log "cannot get controller of..." is too verbose
4 participants