Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid unnecessary updates of discovery service and deployment #1499

Merged
merged 3 commits into from
Jan 9, 2020

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Jan 7, 2020

Signed-off-by: Aylei rayingecho@gmail.com

What problem does this PR solve?

close #1477

Check List

Tests

  • Unit test
  • E2E test

Does this PR introduce a user-facing change?:

Avoid unnecessary updates to `Service` and `Deployment` of discovery

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor Author

aylei commented Jan 9, 2020

/run-all-test

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Contributor

sre-bot commented Jan 9, 2020

cherry pick to release-1.1 in PR #1531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid unnecessary update to discovery service and discovery deployment
4 participants