-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Able to omit storageClassName to use the default storage class of Kubernetes #1581
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -222,9 +222,8 @@ type PDSpec struct { | |
// +optional | ||
Service *ServiceSpec `json:"service,omitempty"` | ||
|
||
// The storageClassName of the persistent volume for PD data storage, empty string means not explicitly set | ||
// and use the cluster default set by admission controller. | ||
// Optionals: Defaults to the default-storage-class-name set in the tidb-operator | ||
// The storageClassName of the persistent volume for PD data storage. | ||
// Defaults to Kubernetes default storage class. | ||
// +optional | ||
StorageClassName *string `json:"storageClassName,omitempty"` | ||
|
||
|
@@ -261,9 +260,8 @@ type TiKVSpec struct { | |
// +optional | ||
MaxFailoverCount *int32 `json:"maxFailoverCount,omitempty"` | ||
|
||
// The storageClassName of the persistent volume for TiKV data storage, empty string means not explicitly set | ||
// and use the cluster default set by admission controller. | ||
// Optionals: Defaults to the default-storage-class-name set in the tidb-operator | ||
// The storageClassName of the persistent volume for TiKV data storage. | ||
// Defaults to Kubernetes default storage class. | ||
// +optional | ||
StorageClassName *string `json:"storageClassName,omitempty"` | ||
|
||
|
@@ -343,9 +341,8 @@ type PumpSpec struct { | |
// +optional | ||
BaseImage string `json:"baseImage"` | ||
|
||
// The storageClassName of the persistent volume for Pump data storage, empty string means not explicitly set | ||
// and use the cluster default set by admission controller. | ||
// Optionals: Defaults to the default-storage-class-name set in the tidb-operator | ||
// The storageClassName of the persistent volume for Pump data storage. | ||
// Defaults to Kubernetes default storage class. | ||
// +optional | ||
StorageClassName *string `json:"storageClassName,omitempty"` | ||
|
||
|
@@ -744,8 +741,10 @@ type BackupSpec struct { | |
Type BackupType `json:"backupType,omitempty"` | ||
// StorageProvider configures where and how backups should be stored. | ||
StorageProvider `json:",inline"` | ||
// StorageClassName is the storage class for backup job's PV. | ||
StorageClassName string `json:"storageClassName,omitempty"` | ||
// The storageClassName of the persistent volume for Backup data storage. | ||
// Defaults to Kubernetes default storage class. | ||
// +optional | ||
StorageClassName *string `json:"storageClassName,omitempty"` | ||
// StorageSize is the request storage size for backup job | ||
StorageSize string `json:"storageSize,omitempty"` | ||
// BRConfig is the configs for BR | ||
|
@@ -866,8 +865,10 @@ type BackupScheduleSpec struct { | |
MaxReservedTime *string `json:"maxReservedTime,omitempty"` | ||
// BackupTemplate is the specification of the backup structure to get scheduled. | ||
BackupTemplate BackupSpec `json:"backupTemplate"` | ||
// StorageClassName is the storage class for backup job's PV. | ||
StorageClassName string `json:"storageClassName,omitempty"` | ||
// The storageClassName of the persistent volume for Backup data storage if not storage class name set in BackupSpec. | ||
// Defaults to Kubernetes default storage class. | ||
// +optional | ||
StorageClassName *string `json:"storageClassName,omitempty"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
// StorageSize is the request storage size for backup job | ||
StorageSize string `json:"storageSize,omitempty"` | ||
} | ||
|
@@ -944,8 +945,10 @@ type RestoreSpec struct { | |
Type BackupType `json:"backupType,omitempty"` | ||
// StorageProvider configures where and how backups should be stored. | ||
StorageProvider `json:",inline"` | ||
// StorageClassName is the storage class for backup job's PV. | ||
StorageClassName string `json:"storageClassName"` | ||
// The storageClassName of the persistent volume for Restore data storage. | ||
// Defaults to Kubernetes default storage class. | ||
// +optional | ||
StorageClassName *string `json:"storageClassName,omitempty"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
// StorageSize is the request storage size for backup job | ||
StorageSize string `json:"storageSize"` | ||
} | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apply the same change from #1409 to backup/restore spec