Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable defaulting for tidbcluster (#1816) #1821

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Feb 28, 2020

cherry-pick #1816 to release-1.1


What problem does this PR solve?

Enable tidbcluster webhook defaulting both in idc configuration and operat chart values.

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

Enable TidbCluster defaulting mutation by default which is recommended when admission webhook is used

@cofyc
Copy link
Contributor

cofyc commented Feb 28, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Feb 28, 2020

/run-all-tests

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Contributor Author

sre-bot commented Feb 28, 2020

@sre-bot merge failed.

@cofyc cofyc merged commit 88aabbc into pingcap:release-1.1 Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/webhook Related to webhook CanMerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants