Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve orphan pods clean logic (#2007) #2009

Merged
merged 2 commits into from
Mar 23, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 23, 2020

cherry-pick #2007 to release-1.1


What problem does this PR solve?

  • check pod has been scheduled or not
  • use ResourceVersion precondition

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

- check pod has been scheduled or not
- use ResourceVersion precondition
@cofyc
Copy link
Contributor

cofyc commented Mar 23, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 23, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 23, 2020

@sre-bot merge failed.

@cofyc
Copy link
Contributor

cofyc commented Mar 23, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 23, 2020

Your auto merge job has been accepted, waiting for 2005, 1906

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 23, 2020

/run-all-tests

@sre-bot sre-bot merged commit 4814131 into pingcap:release-1.1 Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants