Fix sts webhook error #2291
Merged
Fix sts webhook error #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| klog.Infof("statefulset %s/%s has been protect by partition %s annotations", namespace, name, partitionStr) | ||
| return util.ARFail(errors.New("protect by partition annotation")) | ||
| } | ||
| klog.Infof("admit statefulset %s/%s update partition to %d, protect partition is %d", namespace, name, setPartition, partition) | ||
| klog.Infof("admit statefulset %s/%s update partition to %d, protect partition is %d", namespace, name, *stsPartition, partition) |
There was a problem hiding this comment.
stsPartition is possible to be nil here.
cofyc
reviewed
Apr 26, 2020
| if set.Spec.UpdateStrategy.RollingUpdate != nil { | ||
| return &(set.ObjectMeta), set.Spec.UpdateStrategy.RollingUpdate.Partition, nil | ||
| } | ||
| return &(set.ObjectMeta), nil, nil |
There was a problem hiding this comment.
the code seems identical no matter what apiVersion is?
|
Suggested release note: https://github.com/pingcap/tidb-operator/blob/master/docs/release-note-guide.md |
added 3 commits
April 26, 2020 11:13
cofyc
approved these changes
Apr 26, 2020
|
/merge |
|
/run-all-tests |
|
cherry pick to release-1.1 in PR #2306 |
Yisaer
pushed a commit
that referenced
this pull request
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix the error which would cause panic for sts webhook when sts updated strategy is not rolling updated.
Does this PR introduce a user-facing change?: