PD: auto-created failover pods should be deleted when failed members are recovered #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofyc
commented
Apr 27, 2020
| @@ -266,9 +269,6 @@ var _ = ginkgo.Describe("[tidb-operator][Stability]", func() { | |||
| framework.Skipf("current provider is not supported list %v, skipping", supportedProviders.List()) | |||
| } | |||
|
|
|||
| ginkgo.By("Wait for all nodes are schedulable") | |||
| framework.ExpectNoError(framework.WaitForAllNodesSchedulable(c, framework.TestContext.NodeSchedulableTimeout)) | |||
|
|
|||
There was a problem hiding this comment.
this is unnecessary because we will wait for at least 3 schedulable nodes below
|
@Yisaer @DanielZhangQD PTAL |
Yisaer
approved these changes
Apr 28, 2020
|
/merge |
|
/run-all-tests |
|
cherry pick to release-1.1 failed |
sre-bot
added a commit
to cofyc/tidb-operator
that referenced
this pull request
Apr 28, 2020
…upstream-release-1.1
|
Should we add release notes for this fix? @cofyc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #2161
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: