Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create node pool for tiflash and cdc #2413

Merged
merged 3 commits into from
May 11, 2020

Conversation

DanielZhangQD
Copy link
Contributor

@DanielZhangQD DanielZhangQD commented May 9, 2020

What problem does this PR solve?

fix #2376

What is changed and how does it work?

Support creating node pools for tiflash and cdc

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • Deploy EKS with the following config, node pools for tiflash and cdc are created successfully and tiflash Pods can be scheduled to the tiflash nodes.
    create_tiflash_node_pool = true
    create_cdc_node_pool = true
    cluster_tiflash_count = 2
    cluster_cdc_count = 2
    cluster_cdc_instance_type = "c5.large"
    cluster_tiflash_instance_type = "c5d.large"
    
    • Deploy EKS with the following config, node pools for tiflash and cdc will not be created.
    #create_tiflash_node_pool = true
    #create_cdc_node_pool = true
    cluster_tiflash_count = 2
    cluster_cdc_count = 2
    cluster_cdc_instance_type = "c5.large"
    cluster_tiflash_instance_type = "c5d.large"
    

Code changes

  • Has Terraform scripts change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Support creating node pools for tiflash and cdc on EKS

@@ -38,7 +38,7 @@ provider "helm" {

module "default-cluster" {
providers = {
helm = "helm.eks"
helm = helm.eks
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new version of terraform binary will report a warning for the quotes.

@DanielZhangQD DanielZhangQD merged commit 1a6d49b into pingcap:master May 11, 2020
@DanielZhangQD DanielZhangQD deleted the eks-pool branch May 11, 2020 03:30
sre-bot pushed a commit to sre-bot/tidb-operator that referenced this pull request May 11, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 11, 2020

cherry pick to release-1.1 in PR #2419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support creating node pools for tiflash and CDC on EKS with terraform
4 participants