-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Dashboard Metrics Storage Key #2483
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
1a4b29d
auto set prometheus
0bd336e
add grafana
c9875a7
add promethues and grafana
c7a5472
support AlertManager
dbecff3
add alertManager key
18d7e3e
Merge branch 'master' into support_dashboard_key
Yisaer 48172b4
import fmt
d4b6d6b
fix lint
b9873cc
Merge branch 'support_dashboard_key' of https://github.com/Yisaer/tid…
1cb413c
fix lint
6a1ef6f
add grafana enabled
89d2bb9
gen-code
37be87b
fix error
9ec5db3
Update tidbcluster_status_manager.go
84b2938
revise comment
6d4d700
Merge branch 'master' into support_dashboard_key
Yisaer 8929a5c
use new mutex
081243d
Merge branch 'master' into support_dashboard_key
sre-bot 516e320
Merge branch 'master' into support_dashboard_key
sre-bot 7448896
Merge branch 'master' into support_dashboard_key
sre-bot 66a5673
Merge branch 'master' into support_dashboard_key
sre-bot 3c0ded9
Merge branch 'master' into support_dashboard_key
Yisaer 8e16fd6
Merge branch 'master' into support_dashboard_key
Yisaer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status manager should focus on the status update, can we move the etcd key operation to a separate function out of the status manager?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, i think it is not necessary as we only sync etcd key for
MonitorRef
. If there are more new actions for ectd operation, it will be ok for me to split it as an independent manager.