Make StsWebhook and PodWebhook work #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2020 12:19
debug in ci debug ci fix e2e checking add log E2e CI job use memory storage for etcd (pingcap#2633) * support memory storage for etcd in kind * export ETCD_STORAGE_TYPE=memory in e2e_kind.groovy * fix a bug * use KIND_ETCD_DATADIR instead of ETCD_STORAGE_TYPE * fix typos * fix bugs * Revert "fix bugs" This reverts commit 3ae083b. * revert format and simplified extraMounts Hide datasource information for backup job (pingcap#2652) Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com> use crd Update pingcap_tidb_operator_build_kind.groovy
Yisaer
commented
Jun 9, 2020
Comment on lines
+141
to
+144
| tc := fixture.GetTidbCluster(ns, "admission", utilimage.TiDBV3Version) | ||
| tc.Spec.PD.Replicas = 3 | ||
| tc.Spec.TiKV.Replicas = 3 | ||
| tc.Spec.TiDB.Replicas = 2 |
cofyc
reviewed
Jun 9, 2020
| return fmt.Errorf("fail to set annotation for [%s/%s], component: %s, partition: %d, err: %v, output: %s", namespace, tcName, component, ordinal, err, string(output)) | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
use framework.RunKubectl or related functions to run kubectl command, e.g.
tidb-operator/tests/e2e/tidbcluster/tidbcluster.go
Lines 1223 to 1232 in 46ad199
added 2 commits
June 9, 2020 16:59
cofyc
approved these changes
Jun 9, 2020
weekface
approved these changes
Jun 10, 2020
|
/merge |
|
/run-all-tests |
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb-operator
that referenced
this pull request
Jun 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-1.1 in PR #2676 |
sre-bot
added a commit
that referenced
this pull request
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Close #2095
Currently sts webhook and pod webhook couldn't work at the same time because when pod webhook enabled, the sts partition would direct be set as 0.
This pr fix this and make e2e test to ensure it.
Related changes
Does this PR introduce a user-facing change?: