Fix alert rules lost after rolling upgrade #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weekface
commented
Jun 15, 2020
| @@ -67,7 +67,11 @@ spec: | |||
| - name: PROM_PERSISTENT_DIR | |||
| value: /data | |||
| - name: TIDB_VERSION | |||
| {{- if .Values.monitor.prometheus.alertManagerRulesVersion }} | |||
| value: tidb:{{ .Values.monitor.prometheus.alertManagerRulesVersion }} | |||
There was a problem hiding this comment.
Required format of TIDB_VERSION is tidb:vx.x.x.
|
Does |
Yes. Another PR is coming soon which should only be cherry-picked to |
Yisaer
approved these changes
Jun 15, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb-operator
that referenced
this pull request
Jun 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-1.0 in PR #2728 |
ti-srebot
pushed a commit
to ti-srebot/tidb-operator
that referenced
this pull request
Jun 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-1.1 in PR #2729 |
cofyc
pushed a commit
that referenced
this pull request
Jun 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: weekface <weekface@gmail.com>
ti-srebot
added a commit
that referenced
this pull request
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Part of: #2710
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: