Replace controller.Int32Ptr with k8s.io/utils/pointer.Int32Ptr (#2841) #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
@lichunzhu can you cherry-pick it manually? the refactor PR #2841 changed the code which only goes into v1.2, so the automatic cherry-picked PR has conflicts in release-1.1. |
okay |
|
I deleted the file |
cofyc
approved these changes
Jul 1, 2020
|
it seems all goes well |
|
/merge |
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2841 to release-1.1
What problem does this PR solve?
Resolve #2836
What is changed and how does it work?
Replace controller.Int32Ptr with k8s.io/utils/pointer.Int32Ptr
Check List
Tests
Related changes
Does this PR introduce a user-facing change?: