Add support to stop TiDB gracefully (#2810) #2848
Closed
+6,334
−224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2810 to release-1.1
What problem does this PR solve?
This pr add
terminationGracePeriodSeconds
andlifecycle
toTidbCluster
spec.tidb
attribute.User can use these two attributes to stop TiDB server gracefully:
spec.tidb.terminationGracePeriodSeconds
to a proper value, for exmaple:600
(10 minutes).spec.tidb.lifecycle
to:kill -QUIT 1
;The TiDB server will go graceful shutting down to wait for all clients to close the connection until k8s force kill the TiDB container(10 minutes later).
fixes: #2597
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: